Alternative way of listening on all interfaces for the bokeh server#135
Conversation
guillaumeeb
left a comment
guillaumeeb
left a comment
There was a problem hiding this comment.
I think I prefer this way, except I would still bind scheduler itself on all interfaces by default if no interface is provided. This should prove compatible with more network setup as default, even if only on edge cases.
|
And by the way, should we update distributed keyword name? This could break other things I imagine. |
Can you give a quick example of a cluster setup when it is useful to have the scheduler listen on all interfaces? |
|
No I cannot :), I just suspect it could happen. But in such a case workaround would be to pass ip kwargs when initializing cluster object. So nevermind. |
|
@lesteve feel free to revert your last commit, as discussed in previous comment, I don't have a strong argument for listening on all interfaces for scheduler, and if it is needed it can easily be done with kwargs. |
|
I will merge this once travis is OK. |
lesteve
force-pushed
the
bokeh-listen-on-all-interfaces
branch
from
03e7c60 to
3b52f26
Compare
|
Thought I add already pushed flake8 corrections here... Will wait to the end of Travis build to merge (if it is successful). |
2 participants
This is an alternative to #129. Not sure which one is preferable to be completely honest ... one difference that may matter is that the scheduler does not listen on all interfaces.
This is more in the spirit of #90 (comment). I discovered through looking at the source code, that you can pass a
(address, port)address fine to thediagnostics_portdespite its name. Thanks to this, the bokeh diagnostics server will listen on all interfaces.Close #126.